As a Staff Technical Program manager for Enterprise and Compliance, Ben managed GitHub’s on-premises and SaaS enterprise offerings, and as the Senior Product Manager overseeing the platform’s Trust and Safety efforts, Ben shipped more than 500 features in support of community management, privacy, compliance, content moderation, product security, platform health, and open source workflows to ensure the GitHub community and platform remained safe, secure, and welcoming for all software developers. Previously, as Chief of Staff for Security, he managed the office of the Chief Security Officer, improving overall business effectiveness of the Security organization through portfolio management, strategy, planning, culture, and values. For smaller changes, use line-by-line comments with the proposed code.īen Balter is the Director of Engineering Operations and Culture at GitHub, the world’s largest software development platform. When to use it: When you don’t have write access to the source repository (for example, open source), and would like to make substantial changes to an existing pull request created by another user. How it works: You submit a pull request, that instead of requesting a merge into the main branch, requests that its changes be merged into a branch that is the basis of another pull request. It may have been started as a work in progress, or for early feedback, but you’ve made it clear that unless you hear otherwise, you’re going to hit merge. When to use it: When you’re ready to the thing. Team members will comment line-by-line and re-review as you implement their changes. How it works: Submit a feature-complete pull request and cc relevant teams, asking for their review. This may start as a WIP and may end with a line-by-line review. Is this a dumb idea? Is there a better way to do this? The content of the pull request exists to convey the idea, and will likely not be the final implementation. When to use it: When you want feedback on your general approach or the idea itself. How it works: Roughly spike out a feature by creating a proof of concept or rough outline that expressed your idea in its final form. This can be used to prevent the duplication of effort, save work that you’ve started, or complement your team’s workflow. When to use it: When you’ve started a new feature, document, or bugfix, that’s not quite ready for others to review, but you want to let your teammates know that you’re working on the feature. Optionally add emoji and “DO NOT MERGE” in bold if you’re ultra-paranoid. How it works: Prefix the pull request title with WIP. When to use it: When you’ve got a small change, potentially in a part of the codebase outside your area of expertise, and you’d like someone with more experience to provide a quick before your merge the change. How it works: Submit a pull request with a minor change, wait a short period for a sniff-test review, and self merge. When to use it: When you’re making a change so uncontroversial or straight forward that no review is required, but you want to let your teammates know that you’ve made the change. How it works: Create a pull request and immediately merge it yourself without others’ review. Here’s how I see pull requests used at GitHub: Just a heads up I once saw a post that outlined a handful of ways teams use pull requests, that seems to be subsequently lost forever, despite looking high and low. Whether collaborating on code, data, or prose text, there are lots of different strategies for using pull requests on GitHub.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |